Register moz-extension URI scheme for Firefox extension support#477
Open
devrushit wants to merge 1 commit intoexposedev:masterfrom
Open
Register moz-extension URI scheme for Firefox extension support#477devrushit wants to merge 1 commit intoexposedev:masterfrom
devrushit wants to merge 1 commit intoexposedev:masterfrom
Conversation
Firefox browser extensions send requests with `Origin: moz-extension://...` headers. The Laminas UriFactory throws an InvalidArgumentException when parsing this unregistered scheme, which crashes the request logger and prevents proxying. This follows the existing pattern for `capacitor` and `chrome-extension` schemes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moz-extensionURI scheme inUriFactory, following the existing pattern forcapacitorandchrome-extensionOrigin: moz-extension://...headers, which causesLaminas\Uri\Exception\InvalidArgumentException: no class registered for scheme "moz-extension"in the request logger, crashing the proxyContext
When a Firefox extension makes HTTP requests through an Expose tunnel, the browser automatically sets the
Originheader tomoz-extension://<extension-id>. The LaminasUriFactorydoesn't have a handler for this scheme, soLoggedRequest::getRequestHeaders()throws an uncaught exception that prevents the request from being proxied.The fix is a single line, consistent with how
capacitorandchrome-extensionare already handled inAppServiceProvider::boot().Test plan
Origin: moz-extension://...no longer crash the loggercapacitor://andchrome-extension://handling still works